refactor: don't use deprecated SpanAttributes in confluent kafka
#3492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhengkezhou1
changed the title
SpanAttributes in kafkaSpanAttributes in confluent kafka
zhengkezhou1
force-pushed
the
issues-3475-confluent-kafka
branch
from
fa39299 to
92ec06e
Compare
xrmx
reviewed
May 10, 2025
| span.set_attribute(SpanAttributes.MESSAGING_DESTINATION, topic) | ||
|
|
||
| span.set_attribute(MESSAGING_SYSTEM, "kafka") | ||
| span.set_attribute(MESSAGING_DESTINATION_NAME, topic) |
There was a problem hiding this comment.
This task is about updating the import, not changing the semantic conventions so the attributes set should have the same value but imported from another path. If the attribute is not available we must keep using the one from SpanAttributes until we move to a newer semantic convention.
There was a problem hiding this comment.
Got it! take back deleted attribute value now.
There was a problem hiding this comment.
Yeah but still this changes messaging.destination to messaging.destination.name which we don't want to do.
zhengkezhou1
force-pushed
the
issues-3475-confluent-kafka
branch
from
92ec06e to
2f549fb
Compare
xrmx
reviewed
May 27, 2025
| span.set_attribute(SpanAttributes.MESSAGING_DESTINATION, topic) | ||
|
|
||
| if partition is not None: | ||
| span.set_attribute(SpanAttributes.MESSAGING_KAFKA_PARTITION, partition) |
There was a problem hiding this comment.
You changed the attribute name here, it's not the only one and I won't add a comment for every one you changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Stop using
SpanAttributesin kafka.Part of #3475
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Exist test
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.